-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jazzicon to delegate #174
Conversation
✅ Deploy Preview for l2-flexible-voting ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion, otherwise lgtm
pages/[id]/delegate.tsx
Outdated
<InformationCircleIcon | ||
id="delegate-address-information" | ||
className="h-4" | ||
className="h-4 self-start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className="h-4 self-start" | |
className="h-4" |
screenshot shows the info icon is no longer vertically aligned w the text; removing this is the fix. curious, did you not want the icon centered vertically anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good question. I thought it looked better higher, but if you guys think it looks worse I can change it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my preference is centered vertically -- or next to the "Delgated to" rather than the address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description